Skip to content

test(e2e): let database requests finish before the harness advances time #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Oct 9, 2026
Merged

test(e2e): let database requests finish before the harness advances time #1206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions test/e2e/helpers/e2e_app_harness.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,13 @@ class E2eAppHarness {
/// without "Timer is still pending" failures. Call at the end of a scenario.
Future<void> close(WidgetTester tester) async {
await tester.pumpWidget(const material.SizedBox.shrink());
// Let the database requests still in flight finish in real time first.
// Advancing the fake clock in 10 s steps while one is pending fires
// sqflite's "database has been locked" warning, which is noise here: the
// app holds no lock.
await tester.runAsync(
() => Future<void>.delayed(const Duration(milliseconds: 500)),
);
for (var i = 0; i < 6; i++) {
await tester.pump(const Duration(seconds: 10));
}
Expand Down
Loading