Skip to content

test(sql-workspace): run the selection through the mounted editor (#1148) #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Oct 9, 2026
Merged

test(sql-workspace): run the selection through the mounted editor (#1148) #1205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions test/features/workspace/generic_sql_workspace_shortcuts_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,22 +176,30 @@ void main() {
expect(delegate.executed, isEmpty);
});

// Disabled: this test hung CI for the full 10-minute timeout. Selecting
// text by assigning the controller value does not mimic a user selection in
// the editor. Re-enable once the selection is made through the mounted
// editor (EditableTextState.userUpdateTextEditingValue).
testWidgets('only the selected text runs when there is a selection', timeout: _timeout,
skip: true,
(tester) async {
final delegate = FakeSqlExecutionDelegate();
final state = await pumpWorkspace(tester, delegate);
const sql = 'SELECT 1; SELECT 2';
state.activeSession.controller.value = const TextEditingValue(
text: sql,
selection: TextSelection(baseOffset: 10, extentOffset: 18),
final state = await pumpWorkspace(tester, delegate, initialSql: 'SELECT 1; SELECT 2');

// The selection is made through the mounted editor, as a user does; setting
// the controller value directly is what made the test hang before.
final editor = tester.state<material.EditableTextState>(
find.byType(material.EditableText).first,
);
editor.userUpdateTextEditingValue(
const TextEditingValue(
text: 'SELECT 1; SELECT 2',
selection: TextSelection(baseOffset: 10, extentOffset: 18),
),
null,
);
await tester.pump();
expect(state.activeSession.controller.selection.textInside(
state.activeSession.controller.text), 'SELECT 2');

unawaited(state.execute());
await tester.sendKeyDownEvent(LogicalKeyboardKey.controlLeft);
await tester.sendKeyEvent(LogicalKeyboardKey.enter);
await tester.sendKeyUpEvent(LogicalKeyboardKey.controlLeft);
await settle(tester);

expect(delegate.executed, ['SELECT 2']);
Expand Down
Loading