Skip to content

fix(erd): a diagram with every table hidden says so, the empty state names the database (#1157) - #1204

Merged
ZhuchkaTriplesix merged 2 commits into
devfrom
issue/1157-erd-states
Oct 9, 2026
Merged

ZhuchkaTriplesix merged 2 commits into
devfrom
issue/1157-erd-states

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Closes #1157

What was wrong

The toolbar surface, the iconed actions, the Export ▾ menu, the database-based file names and the QueryaEmptyState / QueryaSpinner states were already in place. Still off:

  • A false "No tables found". With every table hidden through "Hide from diagram", the view said "This schema has no tables, or this role cannot see them", although the tables exist. That state had no way to bring them back.
  • The empty state did not say which schema was shown, which the issue asks for.
  • Copy Mermaid was not covered by a test, while the acceptance asks for the Export menu items to be covered (Mermaid and SVG were; PNG came with fix(erd): cap PNG export size, make SVG export look like the screen #1153).

Changes

  • "All tables are hidden" state with the count and a Show all tables action.
  • "No tables found" names the database: "The current schema of <db> has no tables, or this role cannot see them."
  • Tests: Copy Mermaid puts the diagram on the clipboard; hiding every table shows the new state and Show all tables brings them back; the empty state names the database.

…names the database (#1157)

Hiding every table from the diagram showed "No tables found: this schema has
no tables, or this role cannot see them", which is wrong: the tables exist.
That case now has its own state with Show all tables. The empty state for a
schema without tables names the database, and the Export menu's Copy Mermaid
is covered by a test.
@github-actions github-actions Bot added enhancement New feature or request frontend Theme parser epic label: frontend ui User interface components and widgets P2 Medium priority / Parity & Refactoring labels Oct 9, 2026
#1157)

The Copy Mermaid toast starts its 5 s timer after its entry animation, so one
6 s pump left the timer pending. The closing card menu took the tap meant for
Show all tables.
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 6be1f04 into dev Oct 9, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend Theme parser epic label: frontend P2 Medium priority / Parity & Refactoring ui User interface components and widgets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant