Repository navigation
fix(erd): a diagram with every table hidden says so, the empty state names the database (#1157) - #1204
Merged
Conversation
…names the database (#1157) Hiding every table from the diagram showed "No tables found: this schema has no tables, or this role cannot see them", which is wrong: the tables exist. That case now has its own state with Show all tables. The empty state for a schema without tables names the database, and the Export menu's Copy Mermaid is covered by a test.
#1157) The Copy Mermaid toast starts its 5 s timer after its entry animation, so one 6 s pump left the timer pending. The closing card menu took the tap meant for Show all tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1157
What was wrong
The toolbar surface, the iconed actions, the
Export ▾menu, the database-based file names and theQueryaEmptyState/QueryaSpinnerstates were already in place. Still off:Changes
Show all tablesaction.<db>has no tables, or this role cannot see them."Show all tablesbrings them back; the empty state names the database.