Repository navigation
fix(erd): large diagrams fit, Ctrl/Cmd++ zooms, Esc closes the search before the pick (#1154) - #1201
Merged
Merged
Conversation
… before the pick (#1154) Fit stopped at the 20 % zoom floor, so a schema of a few hundred tables did not fit on first load; the floor now follows the fit. Ctrl/Cmd++ is Shift+= on most layouts and was not bound. The search field takes Esc itself (clear, then unfocus), so Esc never closed the search and the canvas lost the keyboard. An empty search that loses the focus now closes and hands the keyboard back; picking a table from the search closes it too. The view's Esc closes an open search first and clears the pick only on the next press. A click on a card or the canvas takes the keyboard, and hiding the picked table clears the pick instead of leaving every card faded.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1154
What was wrong
+is Shift+= on most layouts.QueryaSearchFieldhandles Esc itself (clear the text, then drop the focus), so the view's Esc binding never ran. The panel stayed open and the canvas lost the keyboard: zoom and search shortcuts stopped working until a click.Changes
ErdLayout.fitScale: the fit may go below 20 %; the viewer's minimum zoom follows it.+key zoom in.