Skip to content

feat(sql-workspace): one-row toolbar, Diagram on the tab strip (#1150) - #1198

Merged
ZhuchkaTriplesix merged 3 commits into
devfrom
issue/1150-one-row-toolbar
Oct 9, 2026
Merged

ZhuchkaTriplesix merged 3 commits into
devfrom
issue/1150-one-row-toolbar

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Refs #1150

Changes

  • The toolbar is one row: Run (with its menu), Explain, Cancel while running, then the editor tools as icon buttons (History, Format, Open, Save) with tooltips, then the database name, the transaction badge, Commit / Rollback while a transaction is open, and Session ▾. On a narrow window the row scrolls sideways instead of wrapping.
  • Begin is in Session ▾ only (its inline button is gone). The e2e transaction test opens the menu first.
  • No Query caption and no Data Output bar; the results get the full height.
  • Diagram moves to the right end of the query tab strip (SqlQueryTabBar.trailing), keeping the key open_diagram_tab.
  • Tests: the toolbar stays on one row at 800 px; no caption and no bar.

Already on dev before this PR

Not in this PR

  • Labels hiding below a breakpoint (the row scrolls instead).
  • The elapsed-time badge in the results toolbar (SqlExecutionResult.elapsed).
  • Hiding Diagram when the connection has no diagram source (the extension workspace already sets showDiagram: false; other drivers are not checked here).
  • Commit and Rollback inline only while a transaction is open are in place; the Diagram hide rule for connections without a source is not.

Run, Explain and Cancel are the first group, the editor tools (History, Format,
Open, Save) are icon buttons with tooltips, and the database name, transaction
badge, Commit / Rollback while a transaction is open and the Session menu come
last. The row scrolls sideways on a narrow window instead of wrapping. Begin
lives in the Session menu. The Query caption and the Data Output bar are gone,
and Diagram moves to the right end of the query tab strip.
@github-actions github-actions Bot added enhancement New feature or request frontend Theme parser epic label: frontend ui User interface components and widgets ux User experience, keyboard shortcuts and interactions P2 Medium priority / Parity & Refactoring labels Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Grid scroll benchmark

metric base PR change
p50 15.52 ms 17.05 ms +9.9% ⚠️
p90 24.68 ms 24.63 ms -0.2%
p99 48.90 ms 55.36 ms +13.2% ⚠️
stutters 299.00 288.00 -3.7%

Informational only (threshold 5%). Shared CI runners are noisy; re-run before trusting a single result.

…1150)

QueryaIconButton takes its icon as a widget, not as IconData.
…1150)

The Session menu is a little taller than the Run button, so their top edges
differ while both sit on one row.
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 8791574 into dev Oct 9, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend Theme parser epic label: frontend P2 Medium priority / Parity & Refactoring ui User interface components and widgets ux User experience, keyboard shortcuts and interactions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant