Repository navigation
feat(sql-workspace): one-row toolbar, Diagram on the tab strip (#1150) - #1198
Merged
Merged
Conversation
Run, Explain and Cancel are the first group, the editor tools (History, Format, Open, Save) are icon buttons with tooltips, and the database name, transaction badge, Commit / Rollback while a transaction is open and the Session menu come last. The row scrolls sideways on a narrow window instead of wrapping. Begin lives in the Session menu. The Query caption and the Data Output bar are gone, and Diagram moves to the right end of the query tab strip.
Grid scroll benchmark
Informational only (threshold 5%). Shared CI runners are noisy; re-run before trusting a single result. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1150
Changes
Session ▾. On a narrow window the row scrolls sideways instead of wrapping.Session ▾only (its inline button is gone). The e2e transaction test opens the menu first.Querycaption and noData Outputbar; the results get the full height.SqlQueryTabBar.trailing), keeping the keyopen_diagram_tab.Already on
devbefore this PRNot in this PR
SqlExecutionResult.elapsed).showDiagram: false; other drivers are not checked here).