Repository navigation
refactor(erd): ErdView takes an ErdSource only (#1147) - #1196
Merged
Merged
Conversation
The Diagram tab of the SQL workspace passes its delegate and dialect as a SqlErdSource, so ErdView no longer carries a delegate and dialect pair next to the source. The table browser already passes its own source; the tests build the same SqlErdSource.
github-actions
Bot
added
enhancement
Grid scroll benchmark
Informational only (threshold 5%). Shared CI runners are noisy; re-run before trusting a single result. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1147
Changes
ErdViewtakes anErdSourceonly. The delegate and dialect pair is gone; the SQL workspace's Diagram tab passesSqlErdSource(delegate, dialect). The table browser already passed its own source.SqlErdSource.Already on
devbefore this PRErdSourcewithloadSchemaandloadNeighbourhood, andSqlErdSource/TableDataSqlAdapter(table browser's own session).schema.table; the foreign-key query covers all user schemas.showDiagram: false).Not in this PR
ErdTable.schemaand anErdTableReftype. Schema qualification is still carried inside the name string (schema.table), so a table name containing a dot is still ambiguous. This is why the issue stays open.loadSchema({String? schema}): the source has no schema argument yet.