Repository navigation
feat(workspace): Explain and Cancel in the SQL toolbar - #1131
Merged
Merged
Conversation
…utton in the UI kit (#1051)
Grid scroll benchmark
Informational only (threshold 5%). Shared CI runners are noisy; re-run before trusting a single result. |
Open
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two scenarios still open in #1051 tested features that had no UI:
explainQueryandcancelQueryexisted on the delegate, but nothing called them while a query was running.QueryaActionButton(lib/shared/widgets/querya_action_button.dart): labelled outline toolbar button with icon,loadingspinner,isDestructive, tooltip. The SQL toolbar now uses it for History, Execute, Explain, Cancel, Diagram, Begin, Commit and Rollback instead of seven hand-builtOutlineButtons. Documented indocs/ui-kit.md.delegate.supportsExplain(default true; off for generic extension drivers, which cannot explain).delegate.cancelQuery(); the pending run then ends with the driver's cancellation error.supportsCancelis false for extension drivers, whosecancelQueryis a no-op.e2e_explain_and_cancel_query_test.dart(plan lines, empty editor, error, Cancel interrupts and the editor is usable again, buttons hidden for drivers without support),querya_action_button_test.dart. The fake delegate getsexplainPlan,explainError,cancelAbortsGateand the two support flags.Existing tests that tap
Execute (F5)throughOutlineButtonstill match, since the button wraps one.Written without running locally; CI is the first run.
Closes #1051