Repository navigation
test(e2e): URL dialog, folder move, credential scrubbing and SSH key auth - #1130
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fills the gaps left in #1050:
e2e_url_dialog_test.dart: the New connection from URL modal (parsed summary, create, invalid, empty, cancel).e2e_credential_scrubbing_test.dart: Postgres, MySQL, Redis and Mongo connections drop password and connection string afterscrubCredentials(Zero-Leak).e2e_connection_crud_test.dart: a connection moved into a folder (stored folder id, folder shown in the sidebar). Done through the database, not by dragging.e2e_ssh_bastion_tunnel_test.dart: a passphrase-protected Ed25519 key is kept out of the database, read back from the secure store and opens the tunnel without a password fallback; skipped whenssh-keygenis missing.Written without running locally; CI is the first run.
Part of #1050