Repository navigation
feat(results): export Quick Charts as SVG - #1129
Merged
Merged
Conversation
github-actions
Bot
added
enhancement
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last open criterion of #1061: besides PNG, the chart can be saved as SVG.
ChartSvg.buildrenders bar, line and pie as a standalone SVG from the same points and the workbench / semantic-palette colors, so it follows the current theme; the view gets anExport SVGbutton (onSaveSvgreplaces the file dialog in tests).The SVG is drawn by our own code, not by fl_chart (which cannot export it), so it is a clean version of the chart, not a pixel copy: axes with 5 ticks, labels every n-th point, hover titles on bars, dots and slices, a legend for pies.
Tests:
chart_svg_test.dart(elements per type, escaping, negatives, empty and flat data) and the button inquick_chart_view_test.dart.Written without running locally; CI is the first run.
Closes #1061