Repository navigation
refactor(core): introduce unified QueryaDatabaseException hierarchy - #1085
Merged
Merged
Conversation
… mapper (#1037) Add a sealed QueryaDatabaseException family (auth, host unreachable, timeout, database/table not found, syntax, lock timeout) with remediation hints, a mapper for PostgreSQL, MySQL, SQLite, MongoDB and Redis errors, and use it for connect failures so users see plain messages with hints.
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QueryaDatabaseExceptionfamily inlib/core/database/querya_database_exception.dart:AuthFailedException,HostUnreachableException,ConnectionTimeoutException,DatabaseNotFoundException,TableNotFoundException,QuerySyntaxException,LockTimeoutExceptionand anUnknownDatabaseExceptionfallback. Each carries a message, optional explanation, remediation hint, original error and stack trace.mapDatabaseError/describeDatabaseErrorindatabase_error_mapper.dartmap PostgreSQL, MySQL, SQLite, MongoDB and Redis errors (including wrapped*ConnectionException.cause,SocketException,TimeoutException).connect()rethrow a recognizedQueryaDatabaseException. Unrecognized errors keep their original type and text, so existing typed errors (*ConnectionException) are unchanged.test/core/database/database_error_mapper_test.dart.The existing
*ConnectionExceptionclasses stay as they are; a sealed class cannot be extended outside its library, so they are mapped rather than subclassed.Closes #1037