Skip to content

refactor(workspace): unify table browsers into GenericTableView - #1081

Merged
ZhuchkaTriplesix merged 2 commits into
devfrom
issue/1033-unify-table-browsers
Oct 7, 2026
Merged

ZhuchkaTriplesix merged 2 commits into
devfrom
issue/1033-unify-table-browsers

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

Unifies the duplicated table browser implementations across PostgreSQL, MySQL, SQLite, and Extension drivers into a reusable GenericTableView component and a database-specific TableDataMutationDelegate.

  • Created TableDataMutationDelegate interface to abstract data fetching, custom SQL loading, schema inspection, and DML staging.
  • Created GenericTableView handling pagination, in-place edit mode toggling (Ctrl/Cmd+E, F5), staging buffers (DataGridStagingBuffer), custom SQL results mode, toolbar integration, and results display.
  • Refactored:
    • PostgresTableView -> PostgresTableDataDelegate + GenericTableView
    • MysqlTableView -> MysqlTableDataDelegate + GenericTableView
    • SqliteTableView -> SqliteTableDataDelegate + GenericTableView
    • ExtensionTableView -> ExtensionTableDataDelegate + GenericTableView
  • Preserved existing toolbars, shortcuts, custom action dialogs (DDL, privileges, SQL editor), and custom filter bars.

Closes #1033

@github-actions github-actions Bot added enhancement New feature or request core Core library logic and services ui User interface components and widgets data-grid Interactive data grid, cell editor, filtering, groupings P2 Medium priority / Parity & Refactoring labels Oct 5, 2026
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 46b31cf into dev Oct 7, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core library logic and services data-grid Interactive data grid, cell editor, filtering, groupings enhancement New feature or request P2 Medium priority / Parity & Refactoring ui User interface components and widgets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant