Skip to content

fix(team): profile import crashes on a bad field and the secret scrubber misses pwd / private_key #1564

Closed

Description

@ZhuchkaTriplesix

Problem

TeamProfileCodec.decode (lib/core/team/team_profile.dart:129-133) uses unchecked casts (item['port'] as int?, item['host'] as String?, username, databaseName, authSource, extensionId). A hand-edited or version-skewed file throws TypeError (not TeamProfileFormatException) and the whole import fails instead of skipping the bad row.

The secret scrubber _secretKey (:25) is pass(word|phrase)?|secret|token|api_?key and misses pwd, private_key / privateKey, credential(s), access_key, signature. Such keys in driverOptions or in the connection-string query survive export and import.

Expected

  • Type-check each field (pattern matching), skip invalid rows and report how many were skipped.
  • Extend the key pattern (and add tests for pwd, privateKey, private_key, accessKey, credentials).

Activity

  1. added
    bugSomething isn't working
    stabilityTheme parser epic label: stability
    coreCore library logic and services
    P2Medium priority / Parity & Refactoring
    on Oct 13, 2026
  2. ZhuchkaTriplesix commented on Oct 25, 2026

    @ZhuchkaTriplesix
    MemberAuthor

    Fixed on dev by b9a337c: fix(team): profile import skips and counts unreadable entries instead of throwing; scrub pwd, private keys, ac. It reaches main with the next dev to main merge (closed after checking the code and its tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Medium priority / Parity & RefactoringbugSomething isn't workingcoreCore library logic and servicesstabilityTheme parser epic label: stability

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions