Skip to content

chore(ui): private button classes and ad-hoc InkWell buttons still in lib/features #1445

Closed

Description

@ZhuchkaTriplesix

Problem

After the button migration no shadcn button call is left, but the review found:

  • 7 private button classes: _ActionButton (Mongo collections / databases), _SmallActionButton, _TreeIconButton (20 px target), _ToolbarButton, TableEditModeButton, ThemePickerButton trigger;
  • 14 material.IconButton (password eye in 5 connection forms, the search clear button, the title bar) and about 84 InkWells used as buttons;
  • 6 tooltips with a literal waitDuration and about 230 literal BorderRadius.circular(n).

Scope

Replace each with QueryaButton / QueryaButton.icon / QueryaMenuButton, then land the guards of #1339 with an empty allow-list. One password-field widget for the five eyes.

Found while driving a Linux debug build of dev after the button migration (UI consistency review). Part of epic #1331.

Activity

  1. added
    enhancementNew feature or request
    frontendTheme parser epic label: frontend
    uiUser interface components and widgets
    P3Low priority / Polish & Enhancements
    on Oct 11, 2026
  2. ZhuchkaTriplesix commented on Oct 25, 2026

    @ZhuchkaTriplesix
    MemberAuthor

    Fixed on dev by f8e1827: refactor(ui): private and raw Material buttons leave lib, button guards land (#1476). It reaches main with the next dev to main merge (closed after checking the code and its tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Low priority / Polish & EnhancementsenhancementNew feature or requestfrontendTheme parser epic label: frontenduiUser interface components and widgets

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions