You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor(editor): decouple QueryaCodeEditor from highlight controller lifecycle and manage at session level #1366
This violates clean widget architecture by making the presentation editor responsible for highlight controller lifecycle and state synchronization.
Proposed Solution
Transform QueryaCodeEditor into a clean presentation widget that accepts a single, already-configured TextEditingController (which can be a QueryaHighlightController or plain TextEditingController).
Move highlight controller instantiation, grammar loading, and lifecycle management to SqlQueryTabSession (or a dedicated CodeEditorControllerFactory).
Eliminate the two-way sync loop and full-string comparisons between controllers.
Acceptance Criteria
QueryaCodeEditor does not maintain dual synchronized controllers.
Text editing and syntax highlighting remain fully functional across all workspaces.
Activity
ZhuchkaTriplesix commentedon Oct 11, 2026
Done in #1391 (merged into
dev).