Repository navigation
clustering - #49
Merged
Merged
clustering#49
Conversation
tbdlarsen
reviewed
Nov 7, 2026
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "data_path": "data/geolife.parquet", | |||
| "data_path": "data/geolife_gap60.parquet", | |||
tbdlarsen
reviewed
Nov 7, 2026
| }, | ||
| "clustering": { | ||
| "enabled": false, | ||
| "eps_m": 150.0, |
Contributor
There was a problem hiding this comment.
Why do join and clustering need different distances? 150 vs 500
Contributor
Author
There was a problem hiding this comment.
see next pr about cont frechet. 150 works best, this is just a temporary step. join will also be 150
tbdlarsen
reviewed
Nov 7, 2026
| "eps_m": 500.0 | ||
| }, | ||
| "clustering": { | ||
| "enabled": false, |
Contributor
There was a problem hiding this comment.
why enabled false as standard
Contributor
Author
There was a problem hiding this comment.
It is currently cooked. Next pr fixes it. Its split in two, could prob have been a bit smarter
tbdlarsen
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently disabled. It will be activated once the full continous frechet is added