QUA-1580: Route authenticated tool calls through cloud MCP

[Desperado]

Summary

• route authenticated MCP initialize, discovery, notifications, and non-local tool calls exactly once through the traced cloud MCP endpoint
• keep local-only tools local, preserve unauthenticated standalone behavior, and leave explicit transcript/session lifecycle traffic on REST
• reconcile the cloud registry with tested compatibility aliases/translations and propagate sanitized downstream client identity upstream

Validation

• go test -count=1 -race ./internal/mcp
• go test -count=1 ./...
• go vet ./...
• git diff --check
• independent adversarial review: approved, no blockers

Live validation

A redacted pre-merge production handshake reached the cloud MCP endpoint, but the existing local qmax-code credential is expired (HTTP 401). Successful authenticated live smoke and trace confirmation remain a post-merge closure gate; no credential was displayed or mutated.

Linear: QUA-1580

[sigilix]

---

_{Posted · a7bc951 · 0 findings — View review
Sigilix · 0 of 50 reviews used in past 5h}

Sigilix is reviewing this pull request.

A structured overview will replace this note when retrieval and specialist review complete.

== lighthouse nebula ==
           .       .          .          .        .
      *              .        /\        .              *
              .              /  \             .
        .        .          / || \       .            .
                    .      /  ||  \              *
       *                  /___||___\                  .
              .             __||__         .     .
    .                 ____.'  ||  '.____              *
             *      .'        ||        '.      .
                   /   .      ||     .    \
        .         ;           ||          ;       .
                  |  nebula   ||  listens |
             .    ;      .    ||      .   ;    *
                   \        __||__       /
       *            '.____.'  ||  '.____.'          .
                        /_____|_____\          .
              .        /_/__/_|\__\_\    *

a beam can love the dark it scans
and still ask every shadow why

[qualitymaxapp]

QualityMax Review — canonical overview updated; inline findings are attached to this review.

[qualitymaxapp]

QualityMax Review

Verdict: COMMENT · Confidence: evidence-backed scan

Files eligible: 7 · Files reviewed: 7 · Files with findings: 0 · Findings: 0 · Inline cards: 0

Priority findings

priority	location	finding
—	—	No blocking findings

Review gates

gate	status
AI diff review	completed · eligible 7, reviewed 3 · LLM · served gemini-3.1-flash-lite
SAST	completed · eligible 7, reviewed 7 · hybrid · served gemini-3.1-pro-preview
Overall review evidence	clean
Inline evidence	not needed

Important files

file	risk	note	next step
—	—	No findings	—

Change diagram — Flow

flowchart LR
    Agent[Agent] -->|Call Tool| Client[cloudMCPClient]
    Client -->|POST /api/mcp/| Cloud[Cloud MCP Server]
    Cloud -->|SSE/JSON Response| Client
    Client -->|Result| Agent

Loading

Review lifecycle

Use the inline cards to inspect evidence and suggested remediation. Re-run the QualityMax review after pushing a fix; unchanged cards are identified by their stable finding marker. Dismiss with a reason through the existing QualityMax/GitHub review feedback flow. 0 prior card(s) are stale/resolved on this head. @qmax Q&A is tracked separately.

Proof legend: VERIFIED independently judged patch · REPRODUCED verified finding · GROUNDED deterministic evidence · MODEL-ONLY model judgment.

QualityMax project results are available in the configured project.

_{Receipt · commit a7bc951bfbfb9350e1b3dfca78a7c16bba85cd6d · run 2026-07-28T09:13:45+00:00 · model served gemini-3.1-pro-preview, gemini-3.1-flash-lite · model requested gemini-3.1-pro-preview, gemini-3.1-flash-lite · model review substantive — 1506 model output tokens · model source repository ai_review_preferences.preferred_model · re-review 2 · proof counts {}}

[qualitymaxapp]

⚠️ QualityMax Pipeline

Gate	Result
🔍 AI diff review	✅ Clean · gemini-3.1-flash-lite · completed · 7 eligible / 3 reviewed · gemini-3.1-flash-lite
🔍 SAST	completed · 7 eligible / 7 reviewed · gemini-3.1-pro-preview
🔍 Canonical PR review delivery	completed · 0 eligible / 0 reviewed · exact-head review #4795680140 and overview #5102189400 confirmed
🧪 Repo Tests	❌ 0/0 passed (go)
🤖 AI Tests	⚠️ 0/9 passed

_{Powered by QualityMax — AI-Powered Test Automation}

[qualitymaxapp]

QualityMax Review — canonical overview updated; inline findings are attached to this review.

[Desperado]

Release-gate reconciliation for QUA-1580:

• GitHub CI rerun passed: build-and-test (run 30345657157, attempt 2).
• QualityMax Go Tests rerun passed: Run Go Tests (run 30345653704, attempt 2).
• The external QualityMax Pipeline check remains action_required from the original flaky internal/httpx TestRecordsRequestHashAndSize result. The check app rejected a rerequest, so it cannot reflect the passing rerun.
• The QualityMax reporting step also reports HTTP 401 for its configured integration credential; no credential was displayed or changed.
• Sigilix remains pending; main has no protected required-status-check configuration.

I am treating the passing reruns as the authoritative test evidence. I am not claiming the stale external QualityMax check or Sigilix is green.