Repository navigation
fix: close the #649 review round 4, and cut 0.9.0 - #653
Merged
Merged
Conversation
Review findings: - cite / metadata_only never asked DataCite: metadata_only_doi went from Crossref straight to Unpaywall, so #614's Zenodo concept-DOI choice and --zenodo-version could not run. An enabled DataCite is asked when Crossref has no record; found by the new zenodo_cite_e2e test. - Types keep what they checked: PreprintDoiFallback.preprint_doi is a Doi, PubmedId holds pubmed::Digits, GithubRef's fields are private. - RepeatIndex sweeps only once the map has doubled (amortised O(1)). - add --from-dir names unreadable / non-UTF-8 directory entries. - Simplifications: GithubRef::repo_path, one landing_url in commands/mod, one has_pdf in add, missing::run split into row helpers. - Tests: Zenodo cite (concept by default, --zenodo-version, DataCite off is not asked), INSPIRE asked before ADS, trust_oa_registries alone admits J-STAGE offline. Cut: 0.9.0-beta.30 -> 0.9.0; [Unreleased] -> [0.9.0] - 2026-09-29. release-version-gate.sh v0.9.0: G1-G6 PASS, G7 skipped (no tag yet). Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Signed-off-by: sotashimozono <[email protected]>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the fourth review round of the promotion PR #649 and cuts 0.9.0:
0.9.0-beta.30becomes0.9.0, and## [Unreleased]becomes the curated## [0.9.0] - 2026-09-29. The same pattern as #588 (0.8.13).version-bumpis red here by design. ADR-0033's gate expectsbeta.N+1, and a cut carries a cleanX.Y.Z. On #649 the same check turns green once this lands.Gate
Review round 4 findings, all fixed
A bug the new test found.
doiget citeof a DOI registered with DataCite (Zenodo, figshare) never asked DataCite.metadata_only_doiwent from Crossref straight to Unpaywall, socitenever saw adataciteoutcome. As a result, #614's concept-DOI default and--zenodo-versioncould never run. Now, when Crossref has no record, an enabled DataCite is asked first (datacite_metadata_only). A provenance-log failure still aborts. The fix also applies todoiget_metadata_onlyanddoiget_resolve_paper.Types keep the checks they passed.
PdfLegStatus::PreprintDoiFallback.preprint_doiis aDoiinstead of aString.PubmedIdholdspubmed::Digits, which only its parsers can build.GithubRef's fields are private behind getters.Other fixes.
RepeatIndexsweeps only once the map has doubled since its last sweep, so each insert is amortised O(1).add --from-dirnow names a directory entry it could not read, or one whose name is not UTF-8.Simplifications (no behaviour change).
GithubRef::repo_path.landing_urlincommands/mod.rs, shared bymissingandcoverage.has_pdfinadd.missing::runsplit intounresolved_row,unparsed_row_at,entry_rowandprint_summary.Tests added.
zenodo_cite_e2e(featuremetadata): a version DOI is cited as its concept by default;--zenodo-versionkeeps the version DOI; a disabled DataCite is not asked.inspire_is_asked_before_ads_when_both_are_on: the two mocks name different preprints, and ADS receives no request.trust_oa_registries_alone_admits_jstage: an offline allowlist check.a_sweep_waits_until_the_map_has_doubled; the existing sweep test is updated for the floor.CHANGELOG
add's exit codes.addis marked breaking for scripts.[core]entry, pointing at PUBLIC_API §1a.After merge
next→main) should showversion-bumpgreen.v0.9.0tag is the maintainer's step..claude-plugin/*.json,.mcp.json, the Homebrew formula) are bumped after the release exists, asd962ec5did for 0.8.13.🤖 Generated with Claude Code