Repository navigation
fix: #649 review round 3 -- bounded repeat index and repair match, PUBLIC_API scope - #652
Merged
Merged
Conversation
…BLIC_API scope - RepeatIndex sweeps entries past REPLAY_WINDOW when a new one lands, so doiget serve no longer keeps one per refused ref for its lifetime. - config_fingerprint's config.toml read is a blocking_section. - metadata_quality::restores refuses strings over 2,000 chars and lengths the U+FFFDs cannot explain, and reuses its two buffers. - PUBLIC_API.md §1a: orchestrator / preprint / pubmed / software / user_pdf / repeat / metadata_quality are public for the binaries, not semver-locked; CHANGELOG notes the found_by type change. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Signed-off-by: sotashimozono <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round 3 of 3 of the review of the promotion PR #649. Bumps the version to 0.9.0-beta.30.
Fixed
RepeatIndexgrew without bound (Rust review, HIGH). An entry was removed only on a clean success. Adoiget serveprocess therefore kept one entry for every refused ref for its whole life. Now, when a new entry lands,retaindrops every entry older thanREPLAY_WINDOW, the longest window of any rule. The new testentries_past_every_window_are_swept_when_a_new_one_landscovers it.config_fingerprintreadconfig.tomlwith plainstd::fs::readinside every fetch (Rust review, HIGH). The read now goes throughstore::blocking_section, as store reads do.metadata_quality::restoreson remote strings (Rust review, MEDIUM). The alignment is O(n·m), allocated a new buffer per character, and had no length cap. Now:RESTORE_MAX_CHARS(2,000);Docs
docs/PUBLIC_API.md§1a:orchestrator,preprint,pubmed,software,user_pdf,repeatandmetadata_qualityarepubfor the binaries' use and are not semver-locked (release-readiness review). The CHANGELOG now records thefound_by: FoundBytype change.Round 3 results
addfile handling, remote JSON, CI) found nothing at confidence ≥ 80.🤖 Generated with Claude Code