Cap cbor2 below 6.0.0 (fixes issue 498)#499
Open
pmcorcoran wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cbor2 6.0.0 removed
CBORDecodeValueErroras a backward-incompatible change.cbor2pure 5.8.0 still imports that name, so a clean
pip install pycardanoresolves cbor2 to 6.1.3 and
import pycardanoraises ImportError immediately.This isn't visible in CI because poetry.lock pins cbor2 5.8.0 and uv.lock pins 5.9.0,
and CI installs from the lock. Only users installing from PyPI hit it, which is
users following the README.
Lock files are regenerated for the content-hash only. No resolved versions change,
since 5.8.0/5.9.0 already satisfy the new constraint.
This caps the constraint rather than migrating to cbor2 6.x, which is a larger
effort spanning two packages: cbor2pure re-exports
CBORDecodeValueError(removedin 6.0) across several modules, and pycardano's own serialization.py imports
FrozenDict(renamed tofrozendictin 6.0) and uses it as a type elsewhere.Until both are migrated, capping keeps
pip install pycardanoworking.