Repository navigation
Raise the Go toolchain floor to 1.27.3 - #27
Merged
Merged
Conversation
go1.27.3 (released 2026-10-19) carries a single security fix: GO-2026-6809 (CVE-2026-111943), a denylist in crypto/x509 that makes Certificate.Verify reject known compromised intermediate certificates. govulncheck on go1.27.2 reports it at package level only: crypto/x509 is reached solely through net/http in examples/httpupload, and no code here calls Certificate.Verify. The library core reaches crypto/tls only through a caller-supplied TLS DialFunc. The go directive in go.mod is this project's declared toolchain floor and is expected to carry current stdlib security fixes, so raise it before the scan finding reaches a called symbol: actions/setup-go resolves the floor through go-version-file, and local toolchains fetch it via GOTOOLCHAIN=auto. go1.27.3 lists no bug fixes, so no behavior changes are expected. make verify passes on go1.27.3 and govulncheck -show verbose reports no vulnerabilities at any level. README.md, README.ja.md and CONTRIBUTING.md state "Go 1.27+", which stays accurate and needs no change.
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raise the Go toolchain floor in
go.modfrom 1.27.2 to 1.27.3.go1.27.3 (released 2026-10-19) carries a single security fix: GO-2026-6809 (CVE-2026-111943), a denylist in
crypto/x509that makesCertificate.Verifyreject known compromised intermediate certificates. It lists no bug fixes.On go1.27.2, govulncheck reports GO-2026-6809 at package level only, so the scan still passes: in non-test code
crypto/x509is reached solely throughnet/httpinexamples/httpupload(the root package's tests also importnet/http), and no code here callsCertificate.Verify. The floor is raised now, following the earlier patch bumps (1.26.5, 1.26.6), so it carries current stdlib security fixes before a finding reaches a called symbol. CI resolves the toolchain throughgo-version-file: go.mod, and older local toolchains fetch it viaGOTOOLCHAIN=auto.go.mod:go 1.27.2→go 1.27.3(notoolchainline, norequire).CHANGELOG.md: aChangedentry under[Unreleased]. Downstream modules needgo 1.27.3or later.README.md,README.ja.mdandCONTRIBUTING.mdsay "Go 1.27+", which is still accurate (same precedent as the 1.26.x patch bumps), so they are unchanged.No public API, wire-protocol or security-default change, so no ADR is needed.
Checklist
make verifypasses locally (build + lint + tests) — on go1.27.3: golangci-lint 0 issues, govulncheck-show verbosereports no vulnerabilities at any level, unit tests and the 397-row guard table passmake integrationpasses (required whenclient.go/conn.go/commands.go/internal/proto//docker/changed) — not required here (none of those changed); run anyway, locally on go1.27.3 against the default clamav 1.5 image; CI covers 1.4 and 1.5README.mdandREADME.ja.mdupdated together, or the change touches neitherCHANGELOG.mdupdated under[Unreleased]for user-visible changesReview record
Independent review by a fresh reviewer agent (not the authoring session) against the AGENTS.md Review checklist and the Definition of Done. Reviewed commit:
3df38751712a51d83e82f770d82bf029df4aff1d(origin/main..3df3875, the whole PR). Recommendation: APPROVE. No critical, major or minor findings; all Critical checklist items checked with nothing found. The reviewer independently confirmed the go1.27.3 release contents (milestone holds only the CVE-2026-111943 backport), the GO-2026-6809 advisory, govulncheck results on both toolchains (also with-test), CI resolving exactly go1.27.3, and that no other file references or resolves the Go version.crypto/x509is reached solely throughnet/httpinexamples/httpupload" holds for non-test code only:client_test.goimportsnet/http, so the root package's test binary also linkscrypto/x509(govulncheck -testis still clean)