Repository navigation
Conversation
The models folder was removed with the PID model example. It is back, empty, so that plugin authors see where models of the extensions go; AGENTS.md says so. An empty package does not trigger PMQ109 (only modules other than __init__ count). Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01WLsbwAUCEERmnoWyifx5ZL
seb5g
marked this pull request as ready for review
October 14, 2026 20:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the template had no
models/folder; it was removed with the PID model example (faa6776). Plugin authors had no visible place for models of the extensions.After:
src/pymodaq_plugins_template/models/is back, empty except for an__init__.pydocstring that points to AGENTS.md and themodelsfeature flag. AGENTS.md section 6 now says the folder is shipped empty.How: an
__init__.py-only package is not counted as code bycheck_plugin(_code_filesskips__init__), somodels = falsedoes not raise PMQ109.Tests: 16 of 17 pass locally.
tests/test_plugin_behaviour.py::TestActuator::test_move_homefails in my environment; this change touches no plugin code, so the failure is not caused by it. I did not compare against the base branch.🤖 Generated with Claude Code
https://claude.ai/code/session_01WLsbwAUCEERmnoWyifx5ZL
Generated by Claude Code