Repository navigation
AGENTS.md: required and optional plugin methods follow the PyMoDAQ plugin contract - #56
Merged
Merged
Conversation
…tract of PyMoDAQ Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
AGENTS.mdsaid to "override at least" a long list of methods (includingmove_home,stop_motion,commit_settings) without saying which onescheck_pluginrequires, and the list differed from the one in PyMoDAQ.After: it separates the required methods (actuator:
ini_stage,get_actuator_value,move_abs,move_rel,close; detector:ini_detector,grab_data,stop,close) from the ones to override when the instrument can do it, and points to the single definition inpymodaq_utils.plugin_tools.contractand to the table in the developer guide (PyMoDAQ #1307).How: text change in
AGENTS.mdonly. The template tests need no change: they use the checks of PyMoDAQ, which read the contract. Makingmove_absandmove_relrequired incheck_pluginships with the next PyMoDAQ 5.3.x release.🤖 Generated with Claude Code
https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
Generated by Claude Code