Repository navigation
Models: document the four kinds in AGENTS.md, drop the PID model example - #51
Merged
Merged
Conversation
…ipped The four kinds of models of the extensions are described in a new section of AGENTS.md, which points to the working examples of pymodaq_plugins_mockexamples. The PID model template, whose main() opened an experiment file that is not shipped, is removed and the models flag comment is no longer about PID only. Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
AGENTS.mdsaid nothing about models. The template shipped a PID model whosemain("BeamSteeringMockNoModel.xml")opened an experiment file that is not shipped (with the obsolete "preset" comment), and themodelsflag comment said "pid models" although four extensions use models.After: a new section 6 of
AGENTS.mdlists the four kinds of models (PID, optimizers, data mixer, sequencer), themodels = trueflag and themodels/layout, and points to the working examples ofpymodaq_plugins_mockexamples. The PID model template is removed and the flag comment is general.How: documentation and removal only.
check_plugingives the same findings as before (the template's owntodomarkers) and the package structure test passes. Companion docs change: PyMoDAQ/PyMoDAQ#1294.🤖 Generated with Claude Code
https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
Generated by Claude Code