Repository navigation
Conversation
Replace the copied generic tests with a stub using pymodaq.utils.plugin_testing. The module is skipped with pymodaq < 5.3. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
…, publication, updater) Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
… gate of the CI fails on them Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
seb5g
marked this pull request as ready for review
October 6, 2026 22:30
…e installed in the CI Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/test_plugin_package_structure.py) with a short stub subclassingPluginPackageChecksfrompymodaq_utils.plugin_testing(PyMoDAQ #1256 merged indev, moved topymodaq_utilsin #1259 so that using it does not start the whole pymodaq initialization). The checks are maintained in PyMoDAQ instead of being copied into each plugin, and cover more (entry points, naming, base class + overridden mandatory methods, units/axes consistency,params, static rules on the sources).pymodaq_utils.plugin_testingdoes not exist (PyMoDAQ < 5.3.1: the checks are released in a 5.3 patch version, 5.3.0 being tagged without them). Before that there is no plugin testing, the former tests are dropped.fail_on = 'error'(TODO comments and placeholders are listed, not failing; set'todo'before a release) andstrict_imports = False(a module that cannot be imported because of a missing dependency or vendor driver, that cannot always be installed in a CI, is skipped; set it toTrueto make it fail). An unreplacedpython_wrapper_file_of_your_instrumentimport is reported as a todo, not as a failure.Notes
dev, and the module is skipped whenpymodaq_utils.plugin_testingis not available.5.0.xby 7799554 (Test,Testbase,compatibility,python-publish,updater) are restored, unchanged, as they were just before (196 lines, same as the removal).Testbaseinstallspymodaqfrom PyPI, so the stub is skipped there until a PyMoDAQ release containingpymodaq_utils.plugin_testing(5.3.1) is out. Revert this commit if the removal was intended._epsilonis deprecated indaq_move_Template.py(use_epsilons), and[features]extensions/modelsarefalsewhile the package holds example code in those folders.pymodaq_utils.plugin_testing, is on PyPI: theTestsworkflow of this PR (flake8 gate + pytest with the stub, installingpymodaqfrom PyPI) passes.Testsworkflow fails the flake8 gate on the template itself (F821 undefined name 'arg1','arg2'indaq_move_Template.py): fixed in this PR (PythonWrapperObjectOfYourInstrument()with a TODO for the arguments).🤖 Generated with Claude Code