Repository navigation
2D Mock: remove the non-working 'Use ROISelect' option - #42
Merged
Merged
Conversation
The option cropped the image with self._ROI, only set by the old ROISelect(QRectF) slot that PyMoDAQ no longer calls (plugins now override roi_select(roi_info, ind_viewer)). See the RoiStuff plugin of pymodaq_plugins_mockexamples for a working example of ROI select cropping. Related to PyMoDAQ/PyMoDAQ#1237 Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the Use ROISelect option of
daq_2Dviewer_Mock. It didn't work:self._ROI.self._ROIwas only updated by the oldROISelect(QRectF)slot, which PyMoDAQ no longer calls. Plugins now overrideroi_select(roi_info, ind_viewer).Removed along with it:
ROISelectslot and the_ROIattribute;set_Mock_data;For a working example of cropping to the ROI select, see the RoiStuff plugin of
pymodaq_plugins_mockexamples(PyMoDAQ/pymodaq_plugins_mockexamples#21) and the plugin documentation in PyMoDAQ/PyMoDAQ#1238.Test
I instantiated the plugin headless, initialized it and grabbed: two (200, 100) images, and the option is gone from the settings. The flake8 check (E9, F63, F7, F82, F401) is clean.
Related to PyMoDAQ/PyMoDAQ#1237 (code fixes in PyMoDAQ/PyMoDAQ#1240).
🤖 Generated with Claude Code