Skip to content

Use the plugin acceptance checks provided by PyMoDAQ 5.3.1 - #11

Open
seb5g wants to merge 1 commit into
5.0.xfrom
feature/plugin_acceptance_tests
Open

seb5g wants to merge 1 commit into
5.0.xfrom
feature/plugin_acceptance_tests

Conversation

@seb5g

@seb5g seb5g commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Replace tests/test_plugin_package_structure.py, a copy of the generic tests of pymodaq_plugins_template, by the new stub using the plugin acceptance checks shipped in PyMoDAQ 5.3.1 (pymodaq_utils.plugin_testing, see the documentation and pymodaq_plugins_template PR #43).

  • The old tests only checked that the methods exist (they always do, as they are inherited), stopped silently on import errors and did not check the units/axes, the settings, the entry points...
  • The new checks are made for each instrument module of the package: naming of the module and of the class, base class and overridden mandatory methods, _axis_names / _controller_units / _epsilons, settings tree, entry points, and static rules on the source (deprecated attributes, syntax errors...). Unfinished work (TODO comments...) is listed, not failing.
  • A module that cannot be imported because a dependency or a vendor driver is not available on the CI runner is skipped, not failed (strict_imports = False).
  • The module is skipped when PyMoDAQ is older than 5.3.1.

You can also run check_plugin (PyMoDAQ >= 5.3.1) in the folder of the plugin to get the full report, with the hints to fix each finding.

🤖 Generated with Claude Code

Findings

The package of this repository is still named pymodaq_plugins_template (the stub sets package_name accordingly), and the CI of this PR is red until the following is fixed (not done here):

test_move_plugin[daq_move_Template]: _axis_names defines several axes but is_multiaxes is False

daq_move_Template is the unrenamed example module of the template.

Replace the copy of the generic tests of the plugin template by the stub using
pymodaq_utils.plugin_testing (see pymodaq_plugins_template PR 43). The module is skipped with
older versions of PyMoDAQ.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
@seb5g
seb5g force-pushed the feature/plugin_acceptance_tests branch from 83022f8 to d32b3e8 Compare October 6, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant