Repository navigation
Keep the connect buttons disabled until the app has loaded - #18
Merged
Merged
Conversation
A click on Connect made before the app script had run hit an undefined app and did nothing. The buttons now start disabled and are enabled once the handlers are wired, so an early click waits instead of being lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking Connect before the app finished starting did nothing: the button was live before the script behind it had run, so the click was lost with no message.
The four connect buttons now start disabled and are enabled once the app can act on a click, so an early click waits for the load instead of vanishing.
A new browser test serves the page with the app script held back for three seconds. Before the change the click is lost and the terminal stays empty; after it, the button is disabled, then enabled, and the click connects to the prompt.
Fixes #14