Repository navigation
mip-split.toml: midiports and the USB packages publish to the MIP index by name - #230
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #226.
midiportsand the elevenusb-*packages could only be installed by GitHub URL. From the 0.7.6 release they are in the index under their own names, so this works:and a board config can
require("usb-core").mip-split.tomllists them withtop-level = true; each package's ownmanifest.pystays the source for what it requires and ships, and the index carries the release's version.midiportsinstalls withoutadafruit_midi, which is in no mip index; its README says to use thegithub:install if the board lacks it.docs/usb.mdandmidiports/README.mdsay how to install by name.tests/test_mip_split.pynow also fails when a directory with amanifest.pyandpackage.jsonis missing from the file, or when a listed package requires one that isn't listed.The publisher change this needs is PyDevices/.github#69 (merged); it takes effect once mip uses
publishing-v14.