Repository navigation
Overall connect deadline for boards that flood output - #196
Merged
Merged
Conversation
bdbarnett
force-pushed
the
fix/193-connect-deadline
branch
from
October 30, 2026 04:52
547957a to
3c5bd35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A board printing continuously (for example a machine.Timer callback that never stops) defeats mpremote's between-byte timeout, so connect, ls and exec waited with no explanation. Taking control of a serial board now has a 45 s deadline per attempt (MPFTP_CONNECT_DEADLINE overrides it). When it passes, mpftp stops, without retrying or toggling reset lines, and says the board is printing continuously and that a board with only native USB needs its RESET button.
Tested with a fake transport that streams forever; the test hangs without the change.
Closes #193