Repository navigation
Linux package: mpftp with arguments is the CLI, not the window - #190
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #184.
The .deb puts the desktop app on PATH as
/usr/bin/mpftp, the CLI's own name, and the app ignored its arguments. Sompftp --help, or any CLI command, opened the window and started its Python host and sidecar instead of printing.Started with arguments, the app now replaces itself with the Python it carries running
-m mpftpwith those arguments (andMPFTP_PYTHONset to that Python, so the sidecar uses it too). It never builds a window. A barempftp, which is what the launcher runs, still opens the app. Windows is unchanged: its installer doesn't put the app on PATH, and a GUI-subsystem exe has no console to print to.Reproduced with the 0.1.5rc2 .deb under WSL:
mpftp --helpopened the window and printed nothing untiltimeoutkilled it after 15 s. The bundled/usr/lib/mpftp/python/bin/python3 -m mpftp --helpprints the CLI help.smoke_linux.shnow runsmpftp --helpand--versionfrom the installed package before starting the window, and fails if the help isn't the CLI's or the desktop host starts. The desktop README says the same command is the CLI with arguments.