Repository navigation
Conversation
omip looks on this index first, so a package name shared with micropython-lib would hide theirs. tools/pins.py overlap compares a built index, the untested one included, with micropython-lib's, and the publish workflow runs it after verify. If their index can't be read it warns and carries on. Ran the unit tests, and the check against a local build and the live micropython-lib index: 171 names here, 129 there, none shared. With aioble planted in the local index it fails and names it.
This leaves the overlap check, which fails a publish if a package name is also on micropython-lib.
bdbarnett
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publish workflow gains a check:
omiplooks here first, so a package name shared with micropython-lib would hide theirs.tools/pins.py overlapcompares the built index, including the untested one, with micropython-lib's, and fails naming the package. If their index can't be read it warns and carries on, so their outage doesn't hold up a release.I ran the 16 unit tests, which include this check against local folders, then the command against a local build and the live micropython-lib index: 171 names here, 129 there, none shared. With
aiobleplanted in the local index it exits 1 and names it. The workflow step itself hasn't run on GitHub; it runs at the next publish.