Repository navigation
Conversation
On a wide display that can't turn, the board sits in the middle with space either side, and its touch targets fell in the middle column of a grid spread over the whole screen, so every target read as Drop or Down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a wide framebuffer display that can't rotate (an 800x480 ESP32-P4 panel), testris draws its board in the middle of the screen, but its 3x3 touch grid spanned the whole screen. Both columns of touch targets landed in the grid's middle column, so every tap read as Drop or Down.
The grid now covers the board's border once the layout is known. On a portrait display the board already fills the width, so nothing changes there.
Tested on an ESP32-P4 DEV-KIT (800x480): left, right, rotate and down targets all act as drawn.