Repository navigation
make_faces: write the same licence header the generated files carry - #76
Merged
Merged
Conversation
The generated faces gained the bare comment line in their headers, but the generator's template didn't, so test_face.py found them out of date. Ran make_faces.py --check and tests/test_face.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated instrument faces now carry the three-line licence header, but the generator still wrote two lines, so
tests/test_face.pyreported every face out of date and CI on main fails. This adds the missing line to the generator's template; no generated file changes.make_faces.py --checknow reports 0 faces out of date, andtest_the_faces_are_what_the_classes_saypasses locally. Three other tests in that file fail in my local venv because its audiodsp lacksaudiograph.FOLLOWandWAVETABLE; they passed on CI's newer audiodsp in the previous run, so this PR's CI is the check for them.