Repository navigation
Merged
Conversation
… the rack Its three biquads set audiodsp's BIQUAD_RAMP to one frame, where the option exists, and the five patches waived from the level check for their sweeps now pass it.
The demo's sections moved from about 1450 RMS to about 2550, in line with MonoOne's. Init isn't touched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A graph biquad walks to new coefficients over 20 ms, so a fast filter sweep was duller on the graph than on the rack. StateVariableMono now sets audiodsp's
BIQUAD_RAMPto its shortest on its three filter nodes, behindhasattr, so an older audiodsp still plays. That moves its Init too. TheFAST_SWEEPexception intest_module_patches.pyis gone.Worst 10 ms window, rack against graph, before and after, in dB: Init 2.44 to 0.10, Fat Bass 8.64 to 0.10, Brass Stab 4.67 to 0.14, Nasal Reed 5.82 to 0.08, Wobble Bass 6.86 to 1.28, Squelch Zap 15.65 to 0.73.
The eleven patches after Init are also about 5 dB higher, to sit with the other module voices: the demo's sections go from about 1450 RMS to about 2550, overall RMS 0.044 to 0.077, peak 0.74, nothing clipped. Its traits were accepted with that move.
The floor moves to audiodsp 0.6.13.dev8.