Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro: run
autoflake --recursive --in-place projon a tree whereproj/link.pyis a symlink to a Python file outsideproj/. The target file is rewritten, so a checked-out repository can point the in-place edit at any Python file the user can write.Cause:
find_filespasses every file symlink reported byos.walk()on tofix_file, which reads and writes through the link. Directory symlinks were already not followed, so file symlinks were the only way out of the tree.Fix: skip, before the file is opened, any symlink in the recursive walk whose resolved target is not under the resolved walk root. Symlinks that stay within the tree and files named explicitly on the command line are unchanged. Added a
find_filesregression test that fails on the old code.