feat: export subplot_interferometer_dataset + subplot_fit_interferometer_combined - #668
Merged
Conversation
…ter_combined `autolens.plot` was missing two interferometer plotting symbols that are reachable everywhere else in the stack: - `subplot_interferometer_dataset` is exported by `autogalaxy.plot` from `autoarray.dataset.plot.interferometer_plots`, but `autolens.plot` imported only `subplot_interferometer_dirty_images` and `fits_interferometer` from that same module. The interferometer dataset subplot was therefore unreachable from `autolens.plot`, which is why the autolens_workspace interferometer example has no dataset subplot while its autogalaxy counterpart does. - `subplot_fit_interferometer_combined` is autolens's own function in `autolens/interferometer/plot/fit_interferometer_plots.py`, left unexported while the imaging equivalent `subplot_fit_combined` is exported. Both changes are purely additive. This is the mirror of PyAutoGalaxy#538, which closed the same asymmetry in the other direction. Co-Authored-By: Claude Opus 5 <[email protected]>
This was referenced Jul 30, 2026
Merged
Collaborator
Author
|
Workspace legs of #667 are now open and depend on this PR:
All 7 touched workspace scripts were validated against this branch's build via a shared task worktree (7/7 ran to completion sequentially, with visualization on), so the new exports are exercised by real callers before merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autolens.plotwas missing two interferometer plotting symbols that exist and are reachable everywhere else in the stack. This adds them as pure re-exports.subplot_interferometer_dataset—autogalaxy.plotexports it fromautoarray.dataset.plot.interferometer_plots, butautolens.plotimported onlysubplot_interferometer_dirty_imagesandfits_interferometerfrom that same module and skipped it. The interferometer dataset subplot was therefore unreachable fromautolens.plot, which is whyautolens_workspace/scripts/interferometer/plot.pyhas no dataset subplot while its autogalaxy counterpart does. That was never a workspace gap — the function simply could not be called.subplot_fit_interferometer_combined— autolens's own function inautolens/interferometer/plot/fit_interferometer_plots.py, left unexported while the imaging equivalentsubplot_fit_combinedis exported.This is the mirror of PyAutoGalaxy#538, which closed the same export asymmetry in the other direction during the
plot-guides-restructuretask.Found by an audit of every public function in the source
*_plots.pymodules against everyaplt.*call in both workspaces — the same audit that drives the workspace follow-up (see #667).API Changes
Two symbols added to the
autolens.plot(aplt) namespace. Both are re-exports of existing, unchanged functions — no signature, behaviour, or resolution change to anything already exported. Nothing removed or renamed.See full details below.
Test Plan
set(dir(autogalaxy.plot)) - set(dir(autolens.plot))reduces from{subplot_fit_imaging_list, subplot_interferometer_dataset}to just{subplot_fit_imaging_list}(deliberate — AL usessubplot_fit_combinedinstead of AG'ssubplot_fit_imaging_list)autolensrather than the installed stack:subplot_interferometer_dataset→autoarray.dataset.plot.interferometer_plotssubplot_fit_interferometer_combined→autolens.interferometer.plot.fit_interferometer_plots(autolens's own, not autogalaxy's)apltexport count 61 → 63git diff --stat= 2 files, 5 insertions, 1 deletion — no binary or output leakageFull API Changes (for automation & release notes)
Added
autolens.plot.subplot_interferometer_dataset(dataset, output_path=, output_filename="dataset", output_format=, colormap=, use_log10=False, title_prefix=)— multi-panel subplot of an interferometer dataset. Re-export ofautoarray.dataset.plot.interferometer_plots.subplot_interferometer_dataset, already exported byautogalaxy.plot.autolens.plot.subplot_fit_interferometer_combined(fit_list, output_path=, output_format=, colormap=, title_prefix=)— combined subplot across a list of interferometer fits. Re-export ofautolens.interferometer.plot.fit_interferometer_plots.subplot_fit_interferometer_combined.Removed
None.
Renamed
None.
Changed Signature
None.
Changed Behaviour
None. In particular, the names
subplot_fit_dirty_imagesandsubplot_fit_real_spacecontinue to resolve to the autogalaxy implementations insideautolens.plot, exactly as before this PR.Migration
None required — additive only. Previously unreachable calls now work:
aplt.subplot_interferometer_dataset(dataset=dataset)→AttributeErrorautogalaxy.plot.Deliberately out of scope
Not changed here:
aplt.subplot_fit_dirty_imagesandaplt.subplot_fit_real_spaceresolve to the autogalaxy implementations insideautolens.plot, shadowing autolens's own versions inautolens/interferometer/plot/fit_interferometer_plots.py— which accept lensing-specificimage_plane_lines/source_plane_linesarguments the autogalaxy versions do not. Rebinding an existing exported name is a behaviour change, not an additive export, so it belongs in its own prompt rather than riding along here.Pre-existing
docs/api/plot.rstomissions, not fixed in this PR:subplot_imaging_dataset,subplot_imaging_dataset_list,fits_imaging,fits_interferometer,subplot_fit_interferometer_tracerandsubplot_interferometer_dirty_imagesare all exported but absent from the API docs. Separate audit.Follow-up
The workspace leg of #667 lands after this merges: 7
plot.pyfiles acrossautolens_workspace(imaging, interferometer, weak, cluster, point_source) andautogalaxy_workspace(imaging, interferometer). The AL interferometer dataset subplot depends on the first export here.Closes nothing on its own — #667 stays open until the workspace leg ships.
Generated by the PyAutoLabs agent workflow.