dashboard: an out-link label may wrap — the last nowrap that broke the phone - #174
Merged
Jammy2211 merged 1 commit intoAug 24, 2026
Merged
Conversation
…e phone
The board family's shared theme now makes wrapping the page default
(PyAutoBrain#266) and bounds its chips (PyAutoBrain#270). `white-space:nowrap`
is the one thing an inherited `overflow-wrap` cannot reach, and this file has
two of them. One is fed by data.
`a.out` labels are built from repo names — `f"{name} run"` for a failing row,
`f"{repo} {kind}"` for a hang event — and this org's longest repo name is 36
characters. Under `nowrap` that is a single unbreakable ~500px word, which
sets the summary column's min-content width and takes the whole page with it.
Rendered with a failing row whose link names that repo and measured in a
headless Chromium: a 375px viewport scrolled to 521px, with the summary text
and the details list dragged off the edge alongside the link.
Dropping `nowrap` costs nothing. A short label like `run ↗` has no wrap
opportunity to take, so it is unaffected; a long one now breaks instead of
breaking the page, and the shared theme's `overflow-wrap` does the rest.
Re-measured: 375/375 at a 390px viewport, 305/305 at 320px.
`td.name` keeps its `nowrap`: those titles come from this module's own fixed
vocabulary ("Libraries", "Workspace test-mode timing"), never from repo data,
so it carries no such trap.
603 tests pass, including one pinning the link label.
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01VhpLPmmoSFAtVpppG8azVA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third and last of the mobile-scroll fixes, after PyAutoBrain#266 (wrapping becomes the page default) and PyAutoBrain#270 (chips get bounded).
white-space:nowrapis the one thing an inheritedoverflow-wrapcannot reach, and this file has two of them — one fed by data.The measurement
a.outlabels are built from repo names —f"{name} run"for a failing row (heart/dashboard.py:488),f"{repo} {kind}"for a hang event (:896) — and this org's longest repo name,euclid_strong_lens_modeling_pipeline, is 36 characters. Rendered with a failing row linking that repo, in a headless Chromium at a 375px viewport:Under
nowrapthat label is a single unbreakable ~500px word. It sets the summary column's min-content width, which takes the table — and with it the summary text and the details list in the same cell — off the right edge.The change
Drop
nowrapfroma.out. It costs nothing: a short label likerun ↗has no wrap opportunity to take, so it renders exactly as before; a long one now breaks instead of breaking the page, and the shared theme'soverflow-wrapdoes the rest.td.namekeeps itsnowrapdeliberately — those titles come from this module's own fixed vocabulary (Libraries,Workspace test-mode timing), never from repo data, so they carry no such trap.Caveat worth stating
This is a reproduced overflow of exactly the reported kind, but the offending labels only render when the board has a failing row or a hang event. The live page couldn't be fetched from the session that found this (its Pages host is blocked by the egress policy), so I can't confirm it is what is on screen right now — only that it is the last mechanism by which this page can exceed the viewport.
Tests
603 pass, including one pinning the link label.
Generated by Claude Code