docs(should_simulate): the point-source "not in this gap" note is repo-specific - #480
Merged
Merged
Conversation
…o-specific The Known-gap section stated that point-source datasets "are not in this gap: they write a top-level `data.fits` alongside their JSON and are covered normally". That holds in autolens_workspace. It is false in autolens_workspace_test, whose `.gitignore` lists `data.fits` under "Generated artifacts — never check in", so `dataset/point_source/simple` is three tracked JSON files and nothing else — no `SMALLDAT` stamp can exist there under any placement. That is precisely the directory PyAutoArray#470 was about, so the paragraph reassured the reader about the one case that bit us: the capped branch deleted that committed, allowlist-protected directory on every smoke run. Whether a dataset family is reachable by the stamp is decided per repository by that repo's `.gitignore`, never by the family name. Says so, and points at the PyAutoHands guard (PyAutoHands#252) that enforces what a docstring cannot. Docstring only — no behaviour change. Refs #470 Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01F11sMzmaVWfU6NCz1PKVVb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docstring only — no behaviour change. Refs #470. Paired with PyAutoHands#253, which adds the guard that enforces what a docstring cannot.
The wrong sentence
should_simulate's "Known gap" section currently ends:That holds in
autolens_workspace. It is false inautolens_workspace_test, whose.gitignorelistsdata.fitsunder "Generated artifacts — never check in":No
data.fits⇒ noSMALLDATstamp ⇒_is_capped_at_the_current_capreturns False ⇒ the capped branch deletes the directory.That is precisely the directory #470 was about, so as written the paragraph reassures the reader about the one case that actually bit us — a committed, allowlist-protected dataset destroyed on every smoke run and replaced with degenerate output (
PointSolver.solveshort-circuits to a fixed position pair under the cap).What it says now
The generalisation is replaced with the rule that actually governs: whether a dataset family is reachable by the stamp is decided per repository by that repo's
.gitignore, never by the family name. "Point-source is safe" becomes "point-source is safe wherever a top-leveldata.fitsis actually written", with the counter-example named.It also points at
PyAutoHands'check_dataset_allowlistguard (PyAutoHands#253), which fails apre_buildrun when ashould_simulatecall site that has not releasedPYAUTO_SMALL_DATASETSwould delete git-tracked files.Verification
test_autoarray/util— 88 passed.-k "should_simulate or small_datasets"— 8 passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01F11sMzmaVWfU6NCz1PKVVb