Repository navigation
fix(webhooks): persist tenant-scoped subscriptions across replicas (#447) - #734
Open
woahwhattheheck wants to merge 5 commits into
Open
woahwhattheheck wants to merge 5 commits into
woahwhattheheck wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #447.
This original-author contribution replaces the process-local webhook subscription array with persistent, shared database storage, so subscriptions survive restarts and are accessible from multiple backend replicas. It adds migration
032_create_webhook_subscriptions.sql, tenant-scoped database CRUD, UUID identifiers, async controller operations, and an organization-bound dispatch path. The liquidity-alert caller carries organization context. The existing route-level focused regression checks UUID format and readback of a subscription inserted through a second storage path, reflecting the cross-replica requirement.Original source
woahwhattheheck:fix/payd447-persistent-webhooks-20261008-sol56at93466cce1f9faddff56841482e52927bccf7522a: 5 source commits across exactly 5 files, ahead 5 / behind 0 against sponsor main at submission preflight. No full backend suite, live DB multi-pod deployment, broad CI-green claim, frontend modification or retry redesign is asserted./claim #447
I, @woahwhattheheck, affirmatively claim original-contributor credit and request review for any eligible GrantFox OSS/FWC26 bounty compensation for this issue #447 delivery. Please confirm acceptance, eligibility, any award amount and settlement instructions. No award or actual payment has been confirmed.
Relationship to existing PR #704
The original contributor also has PR #704 for issue #502. The implementations overlap substantially in persistent subscription storage and migration
032_create_webhook_subscriptions.sql. PR #704 additionally implements subscription PATCH CRUD; this PR documents issue #447's cross-replica/tenant-scoping and UUID expectations with its own focused regression. These are alternative overlapping implementation branches and should not be merged independently without reconciling the shared migration and service changes. Please review both issue requirements and preserve attribution to the original author when choosing the integration order. Existing issue-linked reward eligibility remains subject to sponsor evaluation, not automatic payment.