Repository navigation
feat(api): paginate backend list endpoints - #709
Open
woahwhattheheck wants to merge 14 commits into
Open
woahwhattheheck wants to merge 14 commits into
woahwhattheheck wants to merge 14 commits into
Conversation
Author
|
/claim #546 Existing issue claim: #546 (comment) Original contributor and claimant/payee: @woahwhattheheck. Please evaluate PR #709 under the issue's existing GrantFox OSS / Third Campaign bounty route. Current carrier head: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #546
What changed
validate employee-list
page,limit,sort, andorderwith defaults1/20and a maximum limit of100keep employee filtering and SQL
LIMIT/OFFSET, with sorting restricted to an allowlist of real columnsvalidate payroll transaction pagination and canonical
sort/orderparameters while preserving the existingsortBy/sortOrderaliasespropagate validated sort/order through employee, batch, and memo service list paths
put
/payroll/employees/:employeeId,/payroll/batches/:batchId, and/payroll/search/memoon the same page=1 / limit=20 / max=100 route validation contract and returntotalPagesreturn
totalPagesalongside existingpage,limit, andtotalpagination metadataadd audit-log
sort/order, safe SQL column mapping, and the missinglimitresponse fieldpreserve the tenant/filter-matched total on empty out-of-range employee pages;
use the same detail-row predicates for audit counts and results;
retain PostgreSQL parameter placeholders for employee paging and employee/asset audit bindings.
Boundaries
Validation
d2c447736d28cb5bd4d5602458c8011be5f54218— 14 commits, 8 issue-scoped files.d2c44773passed both corrected service bodies: contiguous PostgreSQL bind indices, expected arguments, pagination metadata, and audit results. This was a checked query double, not a live PostgreSQL run or a repository suite; it has not been rerun.37753520851and secrets run37753522107completed as failure with 0 jobs created. No hosted build/runtime green result is established.Contribution and payment
The existing /claim #546 and original contributor/payee @woahwhattheheck remain in place. I am claiming this delivered contribution and requesting the applicable GrantFox Third Campaign payment. Please confirm eligibility, assignment, the reward amount, and the payout method and timing. Application, acceptance, award, and settlement are separate decisions.