fix: add GCP billing section to runbook generator (closes #242) - #246
Merged
Conversation
The generated_agent_runbook_markdown() function in contract.rs was missing the GCP billing env-var table and first-run validation procedure that #237 added manually to the checked-in runbook file. Changed format!(...) to let mut runbook = format!(...); runbook.push_str(...) to append the section without fighting format-string escaping. The push_str approach is cleaner for static documentation blocks. Regenerated docs/agent-mcp-runbook.md — now105 lines with the GCP billing section. Verified idempotent (regen-docs produces same output). Closes #242
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#237 added a GCP billing env-var table and first-run validation procedure to
docs/agent-mcp-runbook.mdmanually, but didn't update thegenerated_agent_runbook_markdown()function incontract.rs. This causedrunbook_is_generated_from_rust_sourceto fail on any branch that merged main after #237.Fix
Appended the GCP billing section to the generator using
push_str()after theformat!()call — avoids the format-string escaping issues that made inline editing impractical. Thepush_strapproach is cleaner for static documentation blocks.Verification
cargo check -p ledgerr-mcppassesregen-docsproduces the GCP billing section (105 lines, up from 80)Closes #242