Repository navigation
PC window: show the first-run setup once - #8
Merged
Merged
Conversation
Setup was marked done only by Done on its last step. Closing the window part-way, which is natural since the main screen has the same QR codes, started it over on every open. Mark it done when it's first shown instead. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported: every time the PC window opens, it walks through the first-run setup again.
Cause.
settings.setupDonewas only set by Done (or Skip) on setup's last step. Closing the window part-way never set it, and that's natural because the main screen has the same QR codes. So the next open started setup over.Fix.
setupDonethe first time it shows setup.Checked. In headless Chromium against
go run ./tools/demo(fresh store), opening the window twice and closing it part-way each time:open 1: setup shown=true,open 2: setup shown=trueopen 1: setup shown=true,open 2: setup shown=false home shown=true🤖 Generated with Claude Code