Repository navigation
App: "went offline" only after two more missed checks - #12
Merged
Merged
Conversation
A phone waking from Doze often reaches no peer for a few seconds while Tailscale reconnects, so one missed background check notified that a computer went offline when it never did. The worker now re-checks twice, 20 s apart. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The background events check (
EventsWorker, about every 15 minutes) said " went offline." after a single missed status call. A phone just out of Doze often can't reach a tailnet peer for a few seconds while Tailscale reconnects, so computers that were on got reported offline, and the app showed them on again when opened.Now a miss is re-checked twice, 20 s apart (
EventsWorker.confirmedOff), and the notification goes out only if the computer stayed unreachable.Tests
UiRulesTest.offlineNeedsTwoMoreMisses: an answer on either re-check cancels it; two more misses confirm it.🤖 Generated with Claude Code