Repository navigation
Conversation
Sentry has reported release 0.5.0 since April because the release id was derived from the hand-maintained API_VERSION. Build it from the Docker build args instead: kaapi-backend@<tag>+<sha12>, with RELEASE_TAG set to the git tag (production) or main (staging). Both deploy workflows now resolve the same id, pass it as a build arg, and register the release and deploy in Sentry after the ECS rollout succeeds, with commits attached (checkout fetch-depth 0). Requires the SENTRY_AUTH_TOKEN secret and SENTRY_ORG / SENTRY_PROJECT / SENTRY_STAGING_PROJECT variables; setup is in docs/runbooks/sentry-release-tracking.md.
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
vprashrex
marked this pull request as draft
October 6, 2026 08:29
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #1155
Summary
API_VERSION, leading to no commits or deploys being attached.Checklist
Before submitting a pull request, please ensure that you mark these task.
fastapi run --reload app/main.pyordocker compose upin the repository root and test.Notes
The Sentry step runs after the ECS rollout so a failed deploy never gets a deploy marker.
fetch-depth: 0on checkout is required forset_commits: auto.Original PR description
Issue
Stacked on #1155. Merge that first; GitHub retargets this PR to
mainautomatically.Summary
Sentry has shown release
0.5.0since April 2026 (0 commits, 0 deploys attached), because the release id came from the hand-maintainedAPI_VERSION. Regressions, "resolved in release" and suspect commits never worked.kaapi-backend@<tag>+<sha12>(v1.7.1for production tags,mainfor staging).SENTRY_RELEASEstill overrides.RELEASE_TAG, and register the release + deploy in Sentry withgetsentry/action-releaseafter the ECS rollout succeeds, with commits attached.docs/runbooks/sentry-release-tracking.md.Checklist
resolve_sentry_release(tag + sha, sha only, unknown sha, override).project:releases,org:read) and addSENTRY_AUTH_TOKENsecret plusSENTRY_ORG,SENTRY_PROJECT,SENTRY_STAGING_PROJECTvariables. Without them the new workflow step fails the deploy job.Notes
The Sentry step runs after the ECS rollout so a failed deploy never gets a deploy marker.
fetch-depth: 0on checkout is required forset_commits: auto.