Repository navigation
fix(platform): Add fallback for GCP and Google-GCP migration script - #1160
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
OpenAPI changes ⚪ No API surface changesNote This PR does not modify the API contract.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
vprashrex
left a comment
There was a problem hiding this comment.
I had approved it, but I would strongly suggest deleting the migration file since it isn’t needed. The google-gcp provider enum already exists in the model_config table.
I’d also suggest seeding the model details using the API for the google-gcp provider.
| # DB that never ran 077. | ||
| with op.get_context().autocommit_block(): | ||
| op.execute( | ||
| "ALTER TYPE global.provider_enum ADD VALUE IF NOT EXISTS 'google-gcp'" |
There was a problem hiding this comment.
google-gcp provider type does exist in global.model_config table. so u don't need to create migration for this and I would suggest u to seed the model using api , not with migration
|
🎉 This PR is included in version 1.5.0-main.14 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Issue
Summary
Checklist
Before submitting a pull request, please ensure that you mark these task.
fastapi run --reload app/main.pyordocker compose upin the repository root and test.Notes
Please add here if any other information is required for the reviewer.
Original PR description
Issue
Closes #PLEASE_TYPE_ISSUE_NUMBER
Summary
Explain the motivation for making this change. What existing problem does the pull request solve?
Checklist
Before submitting a pull request, please ensure that you mark these task.
fastapi run --reload app/main.pyordocker compose upin the repository root and test.Notes
Please add here if any other information is required for the reviewer.