Skip to content

fix(platform): Add fallback for GCP and Google-GCP migration script - #1160

Merged
Prajna1999 merged 7 commits into
mainfrom
fix/platform-fallback-gcp
Aug 27, 2026
Merged

Prajna1999 merged 7 commits into
mainfrom
fix/platform-fallback-gcp

Conversation

@Prajna1999

@Prajna1999 Prajna1999 commented Aug 26, 2026 •

Copy link
Copy Markdown
Collaborator

Issue

Summary

  • Before: No fallback for Google GCP if BYOK is not used.
  • Now: Added platform fallback for Google GCP when not using BYOK.
  • Required adjustments in fallback logic for platform selection.
  • Added google-gcp row along with its model_configs in the "global".model_config table

Checklist

Before submitting a pull request, please ensure that you mark these task.

  • Ran fastapi run --reload app/main.py or docker compose up in the repository root and test.
  • If you've fixed a bug or added code that is tested and has test cases.

Notes

Please add here if any other information is required for the reviewer.

Original PR description

Issue

Closes #PLEASE_TYPE_ISSUE_NUMBER

Summary

Explain the motivation for making this change. What existing problem does the pull request solve?

Checklist

Before submitting a pull request, please ensure that you mark these task.

  • Ran fastapi run --reload app/main.py or docker compose up in the repository root and test.
  • If you've fixed a bug or added code that is tested and has test cases.

Notes

Please add here if any other information is required for the reviewer.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • ready-for-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e49703dc-eb14-4fb8-ac61-6afd8fedb80f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot changed the title fix: platform fallback for google-gcp if not BYOK fix(platform): Add fallback for GCP Aug 26, 2026
@github-actions

github-actions Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

OpenAPI changes   ⚪ No API surface changes

Note

This PR does not modify the API contract.

main ↔ f4c31892 · generated by oasdiff

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Prajna1999 Prajna1999 changed the title fix(platform): Add fallback for GCP fix(platform): Add fallback for GCP and Google-GCP migration script Aug 27, 2026
@Prajna1999
Prajna1999 requested a review from kartpop August 27, 2026 07:51

@vprashrex vprashrex left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had approved it, but I would strongly suggest deleting the migration file since it isn’t needed. The google-gcp provider enum already exists in the model_config table.

I’d also suggest seeding the model details using the API for the google-gcp provider.

# DB that never ran 077.
with op.get_context().autocommit_block():
op.execute(
"ALTER TYPE global.provider_enum ADD VALUE IF NOT EXISTS 'google-gcp'"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

google-gcp provider type does exist in global.model_config table. so u don't need to create migration for this and I would suggest u to seed the model using api , not with migration

@Prajna1999
Prajna1999 merged commit a261a9d into main Aug 27, 2026
4 checks passed
@Prajna1999
Prajna1999 deleted the fix/platform-fallback-gcp branch August 27, 2026 14:58
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.5.0-main.14 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants