refactor(query-engine): remove unused DataFusion query engine - #615
Merged
Conversation
The logical/physical DataFusion plan engine (engines::logical, engines::physical) was superseded by a native implementation in #567. Its only entry points, execute_plan and execute_logical_plan on SimpleEngine, were both #[allow(dead_code)]: execute_logical_plan had zero callers anywhere, and execute_plan was reachable only from tests exercising the DataFusion path directly. Drop those modules, the demo bin that used them, and the DataFusion- specific tests, along with the datafusion/arrow/datafusion_summary_library dependencies they pulled in. Three test files under tests/datafusion/ that don't touch DataFusion (structural/range/dispatch arithmetic tests) move up to tests/ instead of being deleted.
milindsrivastava1997
force-pushed
the
worktree-remove-unused-datafusion
branch
from
August 26, 2026 00:51
48d0079 to
c2b63fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
engines::logical,engines::physical), superseded by a native implementation in asap-query-engine: convert binary PromQL instant queries from DataFusion to native execution #567SimpleEngine::execute_plan/execute_logical_plan, were both#[allow(dead_code)]:execute_logical_planhad zero callers anywhere,execute_planwas reachable only from DataFusion-path testsdatafusion,arrow, anddatafusion_summary_librarydependencies fromasap-query-engine, along with the demo bin (src/bin/show_logical_plans.rs) and DataFusion-specific tests that exercised the dead pathtests/datafusion/that don't actually touch DataFusion (structural_matching_tests.rs,range_query_arithmetic_tests.rs,dispatch_arithmetic_tests.rs) are moved up totests/rather than deletedTest plan
cargo build -p query_engine_rust --tests— clean, no warningscargo test -p query_engine_rust --lib— 466 passed, 0 failedcargo build --workspace— unaffected (other crates still pull indatafusiondirectly)