Skip to content

refactor(query-engine): rename range's window_mode to step_overlap_mode #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milindsrivastava1997 merged 1 commit into from
Aug 25, 2026
Merged

refactor(query-engine): rename range's window_mode to step_overlap_mode #610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions asap-query-engine/src/engines/simple_engine/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1589,7 +1589,11 @@ impl SimpleEngine {
let keys_lookback_ms = context.keys_lookback_ms;
let keys_tumbling_window_ms = context.keys_tumbling_window_ms;

let window_mode = if buckets_per_step <= lookback_bucket_count {
// Named distinctly from `WindowType` (Sliding/Tumbling, picks the store
// fetch call) -- this describes step-to-step overlap in the OUTPUT
// iteration, an unrelated concept that happens to reuse the words
// "sliding"/"hopping". See #581.
let step_overlap_mode = if buckets_per_step <= lookback_bucket_count {
"sliding (slide <= size)"
} else {
"hopping (slide > size)"
Expand All @@ -1603,7 +1607,7 @@ impl SimpleEngine {
tumbling_window_ms,
buckets_per_step,
lookback_bucket_count,
window_mode
step_overlap_mode
);

// Whether the value accumulator's own get_keys() is even consulted
Expand Down
Loading