Repository navigation
ci: test colony-ui on Windows and macOS, install Rust with rustup, and publish the code signing and privacy policy - #20
Merged
Conversation
…d publish the code signing and privacy policy Replace dtolnay/rust-toolchain with rustup in CI, the dependencies workflow and the release template. Run colony-ui's tests on Windows and macOS. Add an action pins job that fails on an unpinned action, a pin without its version comment, or one action pinned at two commits; align upload-artifact on v7.0.2 in the shared workflow so the template and the workflow agree. README: centred header with a tagline, a Status blockquote, a design rules index, Code signing policy and Privacy sections, and License.
The test never ran on Windows, where cache_dir adds 'cache' below Colony/<Program> by design.
…tup-signing-policy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI
dtolnay/rust-toolchainis gone fromci.yml,dependencies.ymlandtemplates/sign-and-publish-caller.yml. Rust is now installed withrustup, which every GitHub-hosted runner image already has. The pinned commit was onmasterand had no version, so Dependabot could not move it. The MSRV job installs the declaredrust-versionand keepsRUSTUP_TOOLCHAIN. The template runsrustup target addfor its matrix target, which the Intel macOS leg needs, withshell: bashso the step also works on Windows.New job
colony-ui tests (windows-latest | macos-latest)runscargo test -p colony-ui --locked. It covers thecfg(windows)andcfg(not linux)paths tests, including the Windows invariant that the cache dir is not the config dir. These tests never ran before.The first Windows run caught a test that had never run there.
every_root_nests_under_the_vendor_then_the_programexpectedcache_dirto end inColony/<Program>, but on Windows it ends inColony\<Program>\cacheby design. The test now drops that component on Windows. The code was already correct.New job
action pinschecks everyuses:in.github/workflows/andtemplates/,release.ymlincluded, and fails when:# vXversion comment (the template's organisation pin of the shared workflow is exempt);Dependabot never reads
templates/, so a Dependabot bump of an action that the template also uses now stays red until the template is bumped in the same PR.actions/upload-artifactinsign-and-publish.ymlgoes from v7.0.1 to v7.0.2, the version the template already used, so the new check passes.persist-credentials: falseon the checkouts in CI and in the dependencies workflow.Docs
design/dependencies.md: install Rust with rustup in CI, and what theaction pinsjob enforces.design/releases.md: a routine action bump inside the shared workflow does not move the organisation pin by itself. It reaches callers with the next pin move, unless it fixes a security advisory. The pin stays at619460fffor now.README.md:> **Status:**blockquote in place of the old## Statussection;## Code signing policysection, since this repository ships no binaries: colony-ui goes to crates.io through Trusted Publishing, and programs are signed by the shared workflow;## Privacysection: the crates collect, store and send nothing, andpathsonly creates the directories it returns;## Licencerenamed to## License.After merge
These repository settings are applied separately:
can_approve_pull_request_reviewskept on;sha_pinning_requiredturned on;tokens and generated artifactsMSRVcolony-ui tests (windows-latest)colony-ui tests (macos-latest)action pinsThe open release PR #18 never started CI. It has to be closed and reopened before it can satisfy those checks.