ci: skip paired-test-PR requirement for doc-only PRs#71
Merged
jnasbyupgrade merged 2 commits intoJul 26, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jnasbyupgrade
marked this pull request as ready for review
July 26, 2026 22:23
check-test-pr now detects when every changed file is pure documentation (*.md, *.asc, *.adoc, *.asciidoc, anywhere including .claude/, but never under .github/) and skips both the paired pgxntool-test PR requirement and the test job entirely, ahead of the paired-branch lookup and the commit-with-no-tests label check. claude-code-review.yml is unaffected (separate workflow, own gate) and still runs. Fixes Postgres-Extensions#62 Co-Authored-By: Claude Sonnet 5 <[email protected]>
A rename like src/foo.sql -> docs/foo.md only exposed the new filename to the doc-only check, so it would incorrectly bypass tests despite changing a non-documentation path. Check previous_filename too. Found by CodeRabbit on the paired pgxntool-test PR: Postgres-Extensions/pgxntool-test#37 (comment) Co-Authored-By: Claude Sonnet 5 <[email protected]>
jnasbyupgrade
force-pushed
the
doc-only-ci-bypass
branch
from
July 26, 2026 22:34
3a425e8 to
95f61b7
Compare
jnasbyupgrade
added a commit
to jnasbyupgrade/pgxntool-test
that referenced
this pull request
Jul 26, 2026
- run-tests.yml: add PostgreSQL 18 to the test matrix. - ci.yml: resolve job gains a doc-only check (every changed file is *.md/*.asc/*.adoc/*.asciidoc, anywhere including .claude/, never under .github/) that gates the test job directly. claude-review is unaffected (separate workflow, own gate). Paired with the equivalent pgxntool-side bypass: Postgres-Extensions/pgxntool#71 Fixes Postgres-Extensions/pgxntool#62 Co-Authored-By: Claude Sonnet 5 <[email protected]>
jnasbyupgrade
added a commit
to Postgres-Extensions/pgxntool-test
that referenced
this pull request
Jul 26, 2026
Related pgxntool PR: Postgres-Extensions/pgxntool#71 Adds PostgreSQL 18 to `run-tests.yml`'s test matrix. Also adds a doc-only bypass to `ci.yml`'s `resolve` job: when every changed file in a PR is pure documentation (`*.md`, `*.asc`, `*.adoc`, `*.asciidoc`, anywhere including `.claude/`, but never under `.github/` — workflow definitions carry real behavioral weight regardless of extension), the `test` job is skipped entirely. Surfaced by PR #36 (a pure `.claude/commands/pr.md` doc change) running the full Postgres test matrix unnecessarily. `claude-review` is unaffected (separate workflow, own gate) and still runs. Fixes Postgres-Extensions/pgxntool#62. --------- Co-authored-by: Claude Sonnet 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check-test-prrequires every pgxntool PR to have a paired pgxntool-test PR (or a maintainer-appliedcommit-with-no-testslabel), with no automatic exemption for PRs that only touch documentation. Surfaced by PR #70 needing a paired test PR for a workflow-only fix, and by pgxntool-test PR #36 (a pure.claude/commands/pr.mddoc change) running its full Postgres test matrix unnecessarily.check-test-prnow detects when every changed file is pure documentation (*.md,*.asc,*.adoc,*.asciidoc, anywhere including.claude/, but never under.github/— workflow definitions carry real behavioral weight regardless of extension) and skips both the paired-branch requirement and the test job entirely, ahead of the paired-branch lookup and thecommit-with-no-testslabel check.claude-code-review.ymlis unaffected (separate workflow, own gate) and still runs.Fixes #62.
Related pgxntool-test PR: Postgres-Extensions/pgxntool-test#37