Skip to content

Fix check-test-pr blocking on non-test checks#68

Closed
jnasbyupgrade wants to merge 1 commit into
Postgres-Extensions:masterfrom
jnasbyupgrade:fix-check-test-pr-filter
Closed

Fix check-test-pr blocking on non-test checks#68
jnasbyupgrade wants to merge 1 commit into
Postgres-Extensions:masterfrom
jnasbyupgrade:fix-check-test-pr-filter

Conversation

@jnasbyupgrade

Copy link
Copy Markdown
Contributor

Problem

check-test-pr inspects every check run on the paired pgxntool-test
PR's head SHA and fails if any conclusion is outside
success/skipped/neutral — including unrelated bots like
claude-review or CodeRabbit, not just the actual test matrix jobs.
Confirmed concretely: pgxntool PR #61's check-test-pr failed with
pgxntool-test PR #31 CI failed for SHA 56e6b14: claude-review (failure) while every test / PostgreSQL <version> job on that PR
was green (root cause of that specific failure: pgxntool-test#33).

Fix

Filter to only check runs belonging to pgxntool-test's own ci.yml
workflow run for that SHA, using each check run's check_suite.id to
identify which workflow produced it (via actions.listWorkflowRuns
scoped to workflow_id: ci.yml). Chose workflow-name filtering over
matching job/check name substrings (test / , Resolve pgxntool branch) so a future rename or added ci.yml job needs no matching
update here, while any other workflow — review bots present or future
— stays excluded regardless of its name. Requires adding actions: read to the job's permissions for the workflow-runs lookup.

Note

This is a workflow-only change with no matching pgxntool-test PR by
design (per this project's convention, a maintainer needs to apply
commit-with-no-tests for check-test-pr to pass — not done here).

Fixes #67

check-test-pr inspected EVERY check run on the paired pgxntool-test
PR's head SHA and failed if any had a conclusion outside
success/skipped/neutral — including unrelated bots like claude-review
or CodeRabbit, not just the actual test matrix. A claude-review failure
(e.g. pgxntool-test#33) transitively failed check-test-pr even when
every test job passed (confirmed on pgxntool PR Postgres-Extensions#61 against
pgxntool-test PR Postgres-Extensions#31).

Filter to only check runs belonging to pgxntool-test's own ci.yml
workflow run for that SHA, using each check run's check_suite.id to
identify which workflow produced it (via actions.listWorkflowRuns
scoped to workflow_id: ci.yml). This is done rather than matching job/
check name substrings ("test / ", "Resolve pgxntool branch") so that a
future rename or added ci.yml job needs no matching update here, while
any other workflow (review bots, present or future) is excluded
regardless of its name. Requires adding `actions: read` to the job's
permissions for the workflow-runs lookup.

Fixes Postgres-Extensions#67

Co-Authored-By: Claude Sonnet 5 <[email protected]>
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6296c8c2-4a0e-4f2d-b144-b14c6a785f09

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jnasbyupgrade

Copy link
Copy Markdown
Contributor Author

We do NOT want this change. See comment on the issue.

@jnasbyupgrade
jnasbyupgrade deleted the fix-check-test-pr-filter branch July 26, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

check-test-pr treats any non-success check on the paired PR as blocking, including non-test bots (claude-review, CodeRabbit)

1 participant